Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Respect go_fmt_options when running goimports #1211

Merged
merged 1 commit into from
Feb 19, 2017

Conversation

cespare
Copy link
Contributor

@cespare cespare commented Feb 19, 2017

I want to use goimports's -local flag, but vim-go ignores go_fmt_options when using goimports for some reason. This just removes that limitation.

@fatih fatih merged commit 2fc67cd into fatih:master Feb 19, 2017
@fatih
Copy link
Owner

fatih commented Feb 19, 2017

Thanks @cespare

@hori-ryota
Copy link
Contributor

@fatih I want to disuse go_fmt_options with GoImports. I have modified it before for using -s option with gofmt.

Disuse go_fmt_options with GoImports by hori-ryota · Pull Request #590 · fatih/vim-go

@fatih
Copy link
Owner

fatih commented Feb 20, 2017

Ok. Thanks for the reminder. Seems like we have to use a different option for goimports ,so it doesn't break goimports when you set a flag that is a valid flag for gofmt, but not goimports

@fatih
Copy link
Owner

fatih commented Feb 20, 2017

I've opened this : #1212 Dont' have time to tackle it now, but will soon. My plan is to introduce a go_goimports_options (or go_imports_options flag). If anyone wants to tackle it let me know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants