Add path convertion for native-win-vim with Cygwin support #1092
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @mikelue for the PR. I'm pretty busy lately, I'm going to go over all the issues soon. Thanks. |
|
Do you know if this plays well with the new Vim 8.0 features? |
|
I am using 8.0.0023，
|
# Conflicts: # autoload/go/path.vim
|
Thanks @mikelue |
fatih
pushed a commit
that referenced
this pull request
May 31, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm using windows and win-vim(x64) with Cygwin. And my environment of
&shellis set to bash of Cygwin.The modifications of PR is to convert path of windows(
C:\go\bin\guru.exe) to$(cygpath 'C:\go\bin\guru.exe').I am not totally sure if this is the best location(
autoload/go/path.vim) to support Cygwin.