Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GoCoverageClear and GoCoverageToggle when syntax is off #817

Closed
fsouza opened this issue Apr 26, 2016 · 3 comments
Closed

GoCoverageClear and GoCoverageToggle when syntax is off #817

fsouza opened this issue Apr 26, 2016 · 3 comments
Labels

Comments

@fsouza
Copy link
Contributor

fsouza commented Apr 26, 2016

Actual behavior

I use vim with syntax off. When I run GoCoverage, it turns syntax on for displaying the colors, but when I run GoCoverageClear or GoCoverageToggle it lets syntax on. Some screeshots:

Right after opening the file:

screen shot 2016-04-26 at 1 01 14 pm

After running GoCoverage:

screen shot 2016-04-26 at 1 00 59 pm

After running GoCoverageClear:

screen shot 2016-04-26 at 1 01 10 pm

### Expected behavior

GoCoverageClear would return the editor to the state it was before invoking GoCoverage.

Steps to reproduce:

Run the following commands:

syntax off
GoCoverage
GoCoverageClear

Configuration

@fatih
Copy link
Owner

fatih commented Apr 26, 2016

This is a bug, should check if the user really uses syntax before I enable it. Good catch. I'll fix it.

@fatih fatih added the bug label Apr 26, 2016
fatih added a commit that referenced this issue Apr 28, 2016
fatih added a commit that referenced this issue Apr 28, 2016
@fatih
Copy link
Owner

fatih commented Apr 28, 2016

This should be now fixed @fsouza. Thanks for the feedback.

@fsouza
Copy link
Contributor Author

fsouza commented Apr 28, 2016

@fatih thanks for fixing it! :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants