Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jumping to a definition via a new vertical window stopped working #2325

Closed
fatih opened this issue May 29, 2019 · 2 comments · Fixed by #2327
Closed

Jumping to a definition via a new vertical window stopped working #2325

fatih opened this issue May 29, 2019 · 2 comments · Fixed by #2327
Labels

Comments

@fatih
Copy link
Owner

fatih commented May 29, 2019

  autocmd FileType go nmap <silent> <Leader>v <Plug>(go-def-vertical)

The above mapping stopped working. It opens the definition in a vertical window, but the cursor is not placed inside the new window. It doesn't jump anymore to the definition.

  • vim-go version: latest HEAD
  • vim version: 8.1.1400

I didn't debugged it yet, just opening it to track it.

@fatih fatih added the bug label May 29, 2019
@bhcleek
Copy link
Collaborator

bhcleek commented May 29, 2019

This is only an issue when g:go_def_mode='gopls' and is happening because the gopls integration doesn't have an exit or close handler. I'll should be able to fix this very soon.

bhcleek added a commit to bhcleek/vim-go that referenced this issue May 29, 2019
@fatih
Copy link
Owner Author

fatih commented May 30, 2019

Thanks Billie. Confirmed that it's fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants