Update versions of Sphinx and its plugins #472
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By adding that CSS class to Harmonica logo we make its background transparent, even on dark mode.
|
With this version of Sphinx and the Book theme, we have dark theme in Harmonica docs. This introduced some issues regarding the rendering of output cells. The ones that show Pandas outputs are working after applying some CSS rules. But for xarray outputs things are harder. Here are screen captures of light vs dark mode with xarray outputs:
|
|
Yeah I noticed that. I think it'll just be a matter of time before xarray makes a fix to their CSS. |
leouieda
approved these changes
Mar 13, 2024
|
Just saw that Xarray's docs make use of Jupyter Books to build them and their HTML outputs look nice on dark theme: https://tutorial.xarray.dev/intermediate/xarray_ecosystem.html |
|
I'm merging this. We can take care of the Xarray inconsistency in another PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bump versions of Sphinx and its plugins in
environment.ymland inrequirements-docs.txt. Add CSSdark-lightclass to Harmonica logo in theindex.rstto make its background transparent even in dark mode. Remove Harmonica logo in the left panel.Relevant issues/PRs:
Similar changes to the ones applied in fatiando/choclo#64