Allow prism_layer to take xarray objects as arguments #243
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extend the support of
prism_layer
to acceptsurface
,reference
, andproperties as
xarray.DataArray
. Improve the test functions by creatinga
pytest
fixture that parametrizes the data types of the output arrays:either Numpy arrays or
xarray.DataArray
s. Generate a newpytest
fixturethat returns a layer of prisms with some holes (missing prisms), ready to be
used as the expected results of some test functions. Parametrize the
field
oneach test function that computes gravitational fields of prism layers. Simplify
the
prism_layer_topo
example so the surface and the density of the layer arepassed as xarray objects.
Reminders:
make format
andmake check
to make sure the code follows the style guide.doc/api/index.rst
and the base__init__.py
file for the package.AUTHORS.md
file (if you haven't already) in case you'd like to be listed as an author on the Zenodo archive of the next release.