Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update a few examples to use Ruby 3.2.1 #219

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

etagwerker
Copy link
Member

A few changes to the README:

  • This benchmark no longer shows a considerable difference so I removed it: attr_accessor vs getter and setter
  • This is no longer accurate: "All results listed in README.md are running with Ruby 2.2.0p0"

I started updating a couple examples and I updated with 3.2.1 results.

@ydakuka
Copy link
Contributor

ydakuka commented Nov 4, 2023

Hey! Are you still working on it?

@etagwerker
Copy link
Member Author

@ydakuka yes 👍

@ydakuka
Copy link
Contributor

ydakuka commented Nov 27, 2023

This rule should be revised due to the upcoming release of Ruby 3.3.

Please see for more information.

8.124M1.8%) i/s - 41.357M in 5.092437s
String#constantize 2.462M2.4%) i/s - 12.315M in 5.004089s
5.028M8.9%) i/s - 25.155M in 5.058707s
String#constantize 3.838M4.3%) i/s - 19.208M in 5.014531s
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be nice to keep both that way we can compare Ruby 2 and Ruby 3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants