Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug for UITabBarController. #2

Closed
xhzengAIB opened this issue Jun 1, 2014 · 17 comments
Closed

bug for UITabBarController. #2

xhzengAIB opened this issue Jun 1, 2014 · 17 comments

Comments

@xhzengAIB
Copy link

Hi! @fastred
Look this picture:
slobug

Jack

@fastred
Copy link
Owner

fastred commented Jun 1, 2014

I can't reproduce it, and I'm not sure why it happens because toViewController's view is inserted below the current view controller's view: https://github.com/fastred/SloppySwiper/blob/master/Classes/SSWAnimator.m#L48

Maybe there's a bug in SSWAnimator but I'm not seeing it right now.

Can you see if it's happening on the physical device too?

@fastred fastred added the bug label Jun 1, 2014
@xhzengAIB
Copy link
Author

@fastred
Ok! I try it.

@xhzengAIB
Copy link
Author

Hi! @fastred
I running on iPhone4, this bug appear.

Jack

@xhzengAIB
Copy link
Author

@fastred
I use this open source(https://github.com/xhzengAIB/MessageDisplayKit) and your open source running on my iPhone4, bug appear.

Jack

@xhzengAIB
Copy link
Author

@fastred
Translation speed not right and the view layers not right.

@fastred
Copy link
Owner

fastred commented Jun 2, 2014

Thanks for preparing the example. I tested it out and it seems to me that hidesBottomBarWhenPushed doesn't work with custom transitions (I reported it as rdar://17093531).

Here's what happens if I remove all transforms from animateTransition: in SSWAnimator:
2014-06-02 17_45_11

UITabBar slides in independently of the previous view controller's view animations (or lack of thereof). One way of fixing it would be to change the view controller hierarchy by embedding UITabBarController inside of UINavigationController. With this hierarchy you wouldn't have to use hidesBottomBarWhenPushed:
screenshot 2014-06-02 17 52 15

@xhzengAIB
Copy link
Author

@fastred
Ok! I try it.

@fastred
Copy link
Owner

fastred commented Jun 3, 2014

I added info about this issue to README in bae450e
I'm not sure anything else can be done to fix it at the moment.

@fastred fastred added the wontfix label Jun 7, 2014
@fastred fastred closed this as completed Jun 7, 2014
@xhzengAIB
Copy link
Author

hi!you fix the bug for tabbarcontroller insert to navigationcontroller?

@fastred
Copy link
Owner

fastred commented Jun 7, 2014

No, but as I wrote earlier:

  • I added a note in README: bae450e
  • I reported this bug to Apple: rdar://17093531

Do you have any ideas how to fix this issue?

@xhzengAIB
Copy link
Author

@fastred
I think should be provided by the apple API is not enough, may be need to apple's support, to solve this issue further.

Jack

@aseemsandhu
Copy link

Any further developments on this issue?

@fastred
Copy link
Owner

fastred commented Aug 22, 2014

You can work around this issue by changing the view controller hierarchy, as I showed in #2 (comment)

The radar is still open.

@fastred fastred reopened this Aug 22, 2014
@wangyang10
Copy link

I have written the same interaction effect 5 months ago, and deal with the issue when navigationbar hidden or tabbar hidesBottomBarWhenPushed.
my repo https://github.com/wangyang10/CustomPopAnimation

@fastred
Copy link
Owner

fastred commented Apr 19, 2015

Should be fixed in #6

@fastred fastred closed this as completed Apr 19, 2015
@yinnieryou
Copy link

Hey, @fastred
I forked this repo and work out this issue.
Here is the address of my repo: https://github.com/yinnieryou/SloppySwiper
I don't know my solution is suitable for you or not, it works perfect on my project.

sloppyswiper

@techabserve
Copy link

Hi. Scrollview not working after push and back to the controller

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants