Improve/test conv lowering convmnist #120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eature/readme_dev_updates Updates to dev docs: pip upgrade, linting
…ngs_attr Feature/strings attr
…p-pool-with-one-worker Avoiding mp.Pool in case of using only 1 worker for easier pdb debugging
…mport_in_notebook_0 fix notebook 0
QuantLSTM (ONNX) QCDQ representation
….com/makoeppel/qonnx into makoeppel-improve/test_conv_lowering_convmnist
|
Thanks @makoeppel ! Looks good. The GitHub Actions CI wasn't triggered for some reason so I took the liberty to merge main and run pre-commit on all files to make an additional push to your branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test
test_conv_lowering_convmnist()failed becauseproducedandexpectedhad one value which was to close (difference >1.e-5) I changed thertolfromassert np.isclose(produced, expected, rtol=1.e-4).all(). I also refactored theLowerConvsToMatMulclass to make it more readable.