Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vitis backend tarball fix #972

Merged
merged 1 commit into from
Feb 21, 2024

Conversation

calad0i
Copy link
Contributor

@calad0i calad0i commented Feb 21, 2024

A# Description

As the current vitis writer only overwrites the headers in nnet_utils after calling the vivado_writer, the tarball produced is with vivado configurations. This PR overrides the tarball generated also.

(Though, do we need to keep the tarball?)

Type of change

For a new feature or function, please create an issue first to discuss it
with us before submitting a pull request.

Note: Please delete options that are not relevant.

  • Bug fix (non-breaking change that fixes an issue)

Tests

Checklist

  • I have read the guidelines for contributing.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have installed and run pre-commit on the files I edited or added.
  • I have added tests that prove my fix is effective or that my feature works.

@jmitrevs jmitrevs added the please test Trigger testing by creating local PR branch label Feb 21, 2024
@jmitrevs
Copy link
Contributor

Did you look at the new tarball to make sure it makes sense?

@calad0i
Copy link
Contributor Author

calad0i commented Feb 21, 2024

Did you look at the new tarball to make sure it makes sense?

Ran a few vitis synths on the generated tarballs (the ones shown in #973). All finished without issue.

@jmitrevs jmitrevs merged commit 9db4237 into fastmachinelearning:main Feb 21, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
please test Trigger testing by creating local PR branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants