-
Notifications
You must be signed in to change notification settings - Fork 409
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Beginnings of the oneAPI backend #955
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmitrevs
added
please test
Trigger testing by creating local PR branch
and removed
please test
Trigger testing by creating local PR branch
labels
Oct 2, 2024
jmitrevs
added
please test
Trigger testing by creating local PR branch
and removed
please test
Trigger testing by creating local PR branch
labels
Oct 2, 2024
jmitrevs
added
please test
Trigger testing by creating local PR branch
and removed
please test
Trigger testing by creating local PR branch
labels
Oct 2, 2024
jmitrevs
added
please test
Trigger testing by creating local PR branch
and removed
please test
Trigger testing by creating local PR branch
labels
Oct 21, 2024
I updated some oneAPI-specific documentation and docstrings. I did not update the status, however, I figure we do that globally before the next release, since I think we also want to remove the "experimental" tag from Vitis. |
JanFSchulte
approved these changes
Oct 22, 2024
jmitrevs
added
please test
Trigger testing by creating local PR branch
and removed
please test
Trigger testing by creating local PR branch
labels
Oct 22, 2024
jmitrevs
added
please test
Trigger testing by creating local PR branch
and removed
please test
Trigger testing by creating local PR branch
labels
Oct 22, 2024
jmitrevs
added
please test
Trigger testing by creating local PR branch
and removed
please test
Trigger testing by creating local PR branch
labels
Oct 24, 2024
JanFSchulte
added
please test
Trigger testing by creating local PR branch
and removed
please test
Trigger testing by creating local PR branch
labels
Oct 24, 2024
vloncar
approved these changes
Oct 25, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great. Many thanks Jovan!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is the beginning of the oneAPI backend, and is just included here for easier sharing and discussion. It is not ready for merging. Currently only
io_parallel
Dense and activation layers are supported.Some things to discuss are:
std::array
for sending data on the pipe, and also between layers. It is generally easier to sendstd::array
than a struct containing C arrays, I believe. (Note,std::array
is passed asnnet::array
, so it's possible to change in one place the array definition.)oneapi_types.py
instead of adding the types infpga_types.py
. I think we want to splitfpga_types.py
. Otherwise catapult types will soon also come there.There is more information on the status at the following link:
https://www.icloud.com/keynote/0e6hRDG4E4PazKCJkJ-ur3yTg#oneAPIDev
Type of change
Tests
oneAPI has been added as a backend in many tests.
Checklist
pre-commit
on the files I edited or added.