-
Notifications
You must be signed in to change notification settings - Fork 409
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated QONNX parsing #832
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 tasks
My understanding of when the dimensions include a batch dimension and when it didn't seems to not be right. Will investigate. For ONNX can't depend on the batch dimension being None. |
jmitrevs
added
enhancement
please test
Trigger testing by creating local PR branch
and removed
please test
Trigger testing by creating local PR branch
labels
Jul 18, 2023
jmitrevs
added
please test
Trigger testing by creating local PR branch
and removed
please test
Trigger testing by creating local PR branch
labels
Aug 2, 2023
This is being replaced with PR #979. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change updates the ONNX parser and adds support for QONNX. It replaces PR #591. It only supports ONNX that has been cleaned by the qonnx package, including converting convolutions to be channels-last and changing
Gemm
toMatMul
andAdd
.In QONNX
Quant
nodes can act on constants as well as the datapath. To make handling this easier, we explicitly put constants in the initial graph. There are also some helper nodes likeMatMul
andConv
that are introduced to support the explicit constant nodes. After theconvert
flow, no special ONNX nodes remain in the graph, though.Generally Quant nodes that have power-of-2 scales and no zero-offset get converted to fixed data types either by setting the types of constants or adding a linear activation that is usually merged into preceding nodes. Non-power-of-2 scales result in
ApplyAlpha
nodes beings added to scale and unscale, with propagation across some layers. This can be further optimized and has generally been tested less.Binary networks are not yet supported.
Currently some of the automatic type setting depends on QONNX-set attributes. When we introduce auto type values, this should be updated accordingly.
Type of change
Tests
The pytest,
test_qonnx.py
, is the main test, building some models from the QONNX model zooChecklist
pre-commit
on the files I edited or added.