Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix parsing of QConv2DBatchnorm weights #802

Merged
merged 2 commits into from
Jun 6, 2023

Conversation

vloncar
Copy link
Contributor

@vloncar vloncar commented Jun 6, 2023

Description

With the recent reorganization of code in the Keras converter, we missed parsing the QConv2DBatchnorm's weights. The fix is a one liner.

Type of change

  • Bug fix (non-breaking change that fixes an issue)

Tests

There's a test added to test_qkeras.py

Checklist

  • I have read the guidelines for contributing.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have installed and run pre-commit on the files I edited or added.
  • I have added tests that prove my fix is effective or that my feature works.

@vloncar vloncar requested a review from jmitrevs June 6, 2023 17:23
@jmitrevs jmitrevs added the please test Trigger testing by creating local PR branch label Jun 6, 2023
@jmitrevs jmitrevs merged commit dc35658 into fastmachinelearning:main Jun 6, 2023
calad0i pushed a commit to calad0i/hls4ml that referenced this pull request Jul 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
please test Trigger testing by creating local PR branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants