[pre-commit.ci] pre-commit autoupdate #796
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pre-commit-ci[bot]](https://avatars.githubusercontent.com/in/68672?s=60&v=4){kind=small}
updates: - [github.com/psf/black: 22.12.0 → 23.3.0](psf/black@22.12.0...23.3.0) - [github.com/asottile/pyupgrade: v3.3.1 → v3.4.0](asottile/pyupgrade@v3.3.1...v3.4.0) - [github.com/pycqa/flake8: 5.0.4 → 6.0.0](PyCQA/flake8@5.0.4...6.0.0)
|
What do people think. Do we merge this? The removal of blank lines may cause some conflicts. |
|
Seems fine to me. |
|
Do you know why the spacing changed? Anyway, unless anyone objects while I am out for lunch I'll merge after. |
|
Yeah, it's a good question. I think this is from black 22 -> 23 (but I could've swore I updated black to 23 earlier.. although looking at this update clearly that's not the case). |
|
I liked some of those empty lines 😢. they brought clarity in the long functions, like in the writer and parts of backend. |
|
Truthfully it's only in a few places where it removes lines. I don't think it's too bad. I'll go ahead and merge it. |
jmitrevs
approved these changes
May 16, 2023
calad0i
pushed a commit
to calad0i/hls4ml
that referenced
this pull request
Jul 1, 2023
…re-commit-ci-update-config [pre-commit.ci] pre-commit autoupdate
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
updates: