Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Jenkins test environment to avoid dependency hell #786

Merged
merged 2 commits into from
May 11, 2023

Conversation

vloncar
Copy link
Contributor

@vloncar vloncar commented May 10, 2023

Description

Jenkins tests are based on python 3.7 environment, in which we can install TF 2.11 as the latest version. When hls4ml is installed on top, onnx dependency causes the update of protobuf package (to 4.21) causing the environment to break and hls4ml (and tensorflow and qkeras) are unusable. We should consider updating the Python requirement to 3.8 for the next version of hls4ml to avoid this, but as an immediate band-aid solution to ensure tests run, we can install onnx==1.12 prior to hls4ml, that won't cause the update of protobuf and the environment works. we can update just the Jenkins environment to Python 3.8.

Type of change

  • Bug fix (non-breaking change that fixes an issue)

Tests

Jenkins tests should run now, they fail on every branch currently.

Checklist

  • I have read the guidelines for contributing.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have installed and run pre-commit on the files I edited or added.
  • I have added tests that prove my fix is effective or that my feature works.

@vloncar vloncar requested a review from jmitrevs May 10, 2023 17:13
@vloncar
Copy link
Contributor Author

vloncar commented May 10, 2023

After a discussion, updated the environment to python 3.8

@vloncar vloncar changed the title Update Jenkins ONNX installation to avoid dependency hell Update Jenkins test environment to avoid dependency hell May 10, 2023
@jmitrevs jmitrevs merged commit 87098f3 into main May 11, 2023
@jmitrevs jmitrevs deleted the jenkins_deps_update branch May 11, 2023 01:32
calad0i pushed a commit to calad0i/hls4ml that referenced this pull request Jul 1, 2023
…enkins_deps_update

Update Jenkins test environment to avoid dependency hell
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants