Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for BatchNormalization layers with center=False or scale=False #754

Merged
merged 5 commits into from
Apr 13, 2023
Merged

Fix for BatchNormalization layers with center=False or scale=False #754

merged 5 commits into from
Apr 13, 2023

Conversation

jmduarte
Copy link
Member

@jmduarte jmduarte commented Apr 9, 2023 •
edited
Loading

  • Fix for batch normalization layers with center=False or scale=False (i.e. beta or gamma are None)

@jmduarte jmduarte linked an issue Apr 9, 2023 that may be closed by this pull request
Converting custom Keras model leads to 'NoneType' object has no attribute 'shape' #578
Closed
@jmduarte jmduarte mentioned this pull request Apr 9, 2023
Closed
@jmduarte jmduarte added the bug label Apr 9, 2023
@jmduarte jmduarte linked an issue Apr 9, 2023 that may be closed by this pull request
Fail to convert BatchNormalization with no gamma or beta #720
Closed
@jmduarte jmduarte requested a review from jicampos April 9, 2023 23:29
@jmitrevs
Copy link
Contributor

What milestone is this for?

jicampos
jicampos approved these changes Apr 11, 2023
View reviewed changes
Copy link
Contributor

@jicampos jicampos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me—only a minor change for the pytorch parser.

Should we add a test for PyTorch models?

@vloncar
Copy link
Contributor

vloncar commented Apr 11, 2023

The current pytorch parser is not developed anymore, we should follow up the changes in the replacement parser in #723.

@jmitrevs jmitrevs added please test Trigger testing by creating local PR branch and removed please test Trigger testing by creating local PR branch labels Apr 11, 2023
@jicampos
Copy link
Contributor

@jmduarte I agree with @vloncar for the PyTorch parser. Would you like to add the fix for Keras now and follow up after #723?

JanFSchulte added a commit to JanFSchulte/hls4ml that referenced this pull request Apr 11, 2023
@JanFSchulte
update parsing of batchnorm layers to match fastmachinelearning#754
d385688
@JanFSchulte
Copy link
Contributor

I have updated #723 to support parsing of the affine argument so it will work with these changes.

@jmitrevs jmitrevs added this to the v0.7.0 milestone Apr 11, 2023
@jmitrevs jmitrevs merged commit 6a27a54 into main Apr 13, 2023
@jmitrevs jmitrevs deleted the batchnorm_fix branch April 13, 2023 00:53
JanFSchulte added a commit to JanFSchulte/hls4ml that referenced this pull request May 23, 2023
@JanFSchulte
update parsing of batchnorm layers to match fastmachinelearning#754
a2eb8c1
calad0i pushed a commit to calad0i/hls4ml that referenced this pull request Jul 1, 2023
@jmitrevs
Merge pull request fastmachinelearning#754 from fastmachinelearning/b…
e60e26e 
…atchnorm_fix

Fix for BatchNormalization layers with `center=False` or `scale=False`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jicampos jicampos jicampos approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
v0.7.0
5 participants
@jmduarte @jmitrevs @vloncar @jicampos @JanFSchulte