Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed sign parsing for ac_fixed and ac_int #727

Merged
merged 5 commits into from
Mar 3, 2023
Merged

Fixed sign parsing for ac_fixed and ac_int #727

merged 5 commits into from
Mar 3, 2023

Conversation

jmitrevs
Copy link
Contributor

@jmitrevs jmitrevs commented Mar 2, 2023

Description

Previously 'ac_fixed<..>' and 'ac_int<..>' strings in the configuration were always parsed as signed. This fixes the issue

Type of change

  • Bug fix (non-breaking change that fixes an issue)

Tests

I added a pytest to just directly call convert_precision_string and make sure that signed was correctly evaluated

Checklist

  • I have read the guidelines for contributing.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have installed and run pre-commit on the files I edited or added.
  • I have added tests that prove my fix is effective or that my feature works.

@jmitrevs jmitrevs added bug please test Trigger testing by creating local PR branch labels Mar 2, 2023
@jmitrevs jmitrevs requested a review from vloncar March 2, 2023 23:31
@jmitrevs jmitrevs added please test Trigger testing by creating local PR branch and removed please test Trigger testing by creating local PR branch labels Mar 2, 2023
@jmitrevs
Copy link
Contributor Author

jmitrevs commented Mar 2, 2023

I seem to have trouble initiating CI. Any suggestion?

@vloncar vloncar added please test Trigger testing by creating local PR branch and removed please test Trigger testing by creating local PR branch labels Mar 3, 2023
@vloncar vloncar merged commit 5ac737c into fastmachinelearning:main Mar 3, 2023
calad0i pushed a commit to calad0i/hls4ml that referenced this pull request Jul 1, 2023
@jmitrevs
Fixed sign parsing for ac_fixed and ac_int (fastmachinelearning#727)
04f0aab 
* fix sign parsing for ac_fixed and ac_int

* add a lower for false comparison in ac_fixed/int parsing, simplify logic

* update precision parsing

* add some comments

* remove print
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vloncar vloncar vloncar approved these changes

Assignees
No one assigned
Labels
bug please test Trigger testing by creating local PR branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jmitrevs @vloncar