Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix function call in Alveo tcl script #694

Merged
merged 1 commit into from
Jan 18, 2023

Conversation

vloncar
Copy link
Contributor

@vloncar vloncar commented Dec 14, 2022

Description

After changes in #626 the file list passed to the add_files and import_files tcl functions is using a variable, but the {...} syntax doesn't do expansion so the name of the file is never properly made, causing the script to fail. This can be solved in several ways buy since the functions expect list of strings, the cleanest approach is to use [list ...].

Type of change

  • Bug fix (non-breaking change that fixes an issue)

Tests

Not really needed, this is a syntax fix.

Checklist

  • I have read the guidelines for contributing.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have installed and run pre-commit on the files I edited or added.
  • I have added tests that prove my fix is effective or that my feature works.

Copy link
Contributor

@jmitrevs jmitrevs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you rebase and make sure the tests finish successfully?

@jmitrevs jmitrevs added please test Trigger testing by creating local PR branch bug labels Jan 18, 2023
@jmitrevs jmitrevs merged commit 1c2acbb into fastmachinelearning:main Jan 18, 2023
calad0i pushed a commit to calad0i/hls4ml that referenced this pull request Jul 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug please test Trigger testing by creating local PR branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants