Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use wider accum_t for (average) pooling #681

Merged
merged 1 commit into from
Nov 9, 2022

Conversation

vloncar
Copy link
Contributor

@vloncar vloncar commented Nov 8, 2022

Description

As discussed in 656 io_stream implementation of AveragePooling doesn't use the wider type for summing up the values of the pool window. This fixes it (bugs 1 and 2 from that discussion).

I'd appreciate an expedited review so that we can merge #656 (the test in main branch will fail if we merge that one before this one).

Type of change

  • Bug fix (non-breaking change that fixes an issue)

Tests

I expanded the test_cnn_mnist.py to include io_stream implementations where this issue was first observed.

Checklist

  • I have read the guidelines for contributing.
  • I have commented my code, particularly in hard-to-understand areas.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.

Copy link
Contributor

@bo3z bo3z left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, these changes should now be replicated in #656

@vloncar vloncar merged commit b180fe1 into fastmachinelearning:main Nov 9, 2022
@vloncar vloncar deleted the avgpool_accum_fix branch November 9, 2022 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants