Use wider accum_t for (average) pooling #681
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As discussed in 656
io_stream
implementation of AveragePooling doesn't use the wider type for summing up the values of the pool window. This fixes it (bugs 1 and 2 from that discussion).I'd appreciate an expedited review so that we can merge #656 (the test in main branch will fail if we merge that one before this one).
Type of change
Tests
I expanded the
test_cnn_mnist.py
to includeio_stream
implementations where this issue was first observed.Checklist