Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix parsing of logic synthesis reports #639

Merged
merged 1 commit into from
Aug 16, 2022
Merged

Fix parsing of logic synthesis reports #639

merged 1 commit into from
Aug 16, 2022

Conversation

vloncar
Copy link
Contributor

@vloncar vloncar commented Aug 16, 2022

Description

Due to changes in the format of the Vivado (logic) synthesis, the parsing function is broken and zeros are returned. This fix ensures only the appropriate sections are parsed.

Type of change

  • Bug fix (non-breaking change that fixes an issue)

Tests

report = hls4ml.report.parse_vivado_report('/path/to/my/hls/outout/dir')
print(report['VivadoSynthReport'])

Observe before and after.

@vloncar vloncar requested a review from jmitrevs August 16, 2022 15:28
@jmitrevs
Copy link
Contributor

I think this needs some of the fixes in #626 in order for part 1 of the hls4ml-tutorial to work. So I would approve it, but only after #626.

@jmitrevs jmitrevs merged commit 50cf296 into fastmachinelearning:main Aug 16, 2022
@vloncar vloncar deleted the vsynth_report_fix branch August 16, 2022 17:17
calad0i pushed a commit to calad0i/hls4ml that referenced this pull request Jul 1, 2023
@jmitrevs
Merge pull request fastmachinelearning#639 from vloncar/vsynth_report…
70c57e7 
…_fix

Fix parsing of logic synthesis reports
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmitrevs jmitrevs jmitrevs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vloncar @jmitrevs