Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QConv alpha != 1 bug fix #612

Merged
merged 1 commit into from
Jul 28, 2022

Conversation

bo3z
Copy link
Contributor

@bo3z bo3z commented Jul 19, 2022

A# Description

📝 Please include a summary of the change.
When using alpha='auto' an exception is thrown because Conv1D & Conv2D have no attribute n_in, n_out which is needed for the ApplyAlpha layer config template

Type of change

  • Bug fix (non-breaking change that fixes an issue)

Tests

📝 Please describe the tests that you ran to verify your changes.
To reproduce error, run most up-to-date version of hls4ml with the following QKeras model:

keras_model = Sequential()
keras_model.add(QConv2D(4, (3, 3), input_shape=(4, 4, 1), kernel_quantizer=quantized_bits(4, 0, alpha='auto')))
keras_model.compile()
  • I have read the guidelines for contributing.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.B

@vloncar vloncar merged commit 62046d7 into fastmachinelearning:main Jul 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants