-
Notifications
You must be signed in to change notification settings - Fork 409
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
change master to main #602
Conversation
Referring to the change to the workflow build-sphinx.yml, this could also be an opportunity to switch to run that workflow on tag/release rather than commit to main. |
I think recent Jenkins test failures relate to this also, for example this fetch references
I don't think this is specified in any of our test code, Edit: this is fixed with a |
For the sphinx workflow, I have to admit I am not too familiar, but would it make sense that on main it build main, but on a release branch or tag it build the documentation for that tag? That should probably be the official version we upload. |
What do people think about this? The changes are minor, so I would propose merging it. About the proposed sphinx workflow change, I think that can be separate. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the changes look good to me. Also, for now we can keep the sphinx workflow running on main in case we "backport" documentation updates that describe prior releases.
…ain-name-update change master to main
Description
This PR is just for any changes that we need to make while renaming master to main.
Type of change
For a new feature or function, please create an issue first to discuss it
with us before submitting a pull request.
Note: Please delete options that are not relevant.
Tests
Test Configuration:
Checklist