-
Notifications
You must be signed in to change notification settings - Fork 409
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove cppname #562
remove cppname #562
Conversation
Cleaning the name at that point would in fact break the model if a change actually happened. |
For Quartus we rename |
I would like if possible to have this merged fairly soon since it effects new developments, which have to consider this PR. |
This looks fine to me, I tried it on my Vivado developments and nothing breaks. But Quartus worries me a bit. I remember (ab)using |
I've tested this a couple of days ago, all the tests pass and synthesis is
successful. I'm happy to merge this. Once merged I will have to rebase and
reflect these changes in the streaming PR, but I would rather merge #562
first.
…On Tue, 12 Jul 2022, 18:41 vloncar, ***@***.***> wrote:
This looks fine to me, I tried it on my Vivado developments and nothing
breaks. But Quartus worries me a bit. I remember (ab)using cppname there
for something. @bo3z <https://github.com/bo3z> Can you try this out and
if there are no issues we merge it ASAP?
—
Reply to this email directly, view it on GitHub
<#562 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AOIYLWZJOQUBBE3HBKA3GDDVTWN5DANCNFSM5XV72MSA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Variable
name
andcppname
are often used interchangeably in the code, not consistently. My understanding is thatcppname
was meant to be a cleaned up C-legal version of name. Instead of looking at each case wherename
is used and trying to see if it should becppname
and vice versa, it probably makes sense to just get rid ofcppname
altogether, and just usename
everywhere.One question is whether we want to include this name cleaning in the
Variable.__init__
function:I have not included it. The standard pytests all pass without it.