Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

returning integer from _compute_n_samples #537

Merged
merged 4 commits into from
Jun 19, 2022

Conversation

JochiSt
Copy link
Contributor

@JochiSt JochiSt commented May 2, 2022

I changed the return type of _compute_n_samples to int.

See issue #536 for the error message I get otherwise.

When the input data is a single number, the test data is a one-dimensional
array. From this array one number was forwareded to top_function. Changing this
into an array solved this issue.
@jmduarte jmduarte self-requested a review June 19, 2022 04:19
@jmduarte jmduarte linked an issue Jun 19, 2022 that may be closed by this pull request
Copy link
Member

@jmduarte jmduarte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jmduarte jmduarte merged commit eb9f3b4 into fastmachinelearning:master Jun 19, 2022
calad0i pushed a commit to calad0i/hls4ml that referenced this pull request Jul 1, 2023
returning integer from _compute_n_samples
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issue with hlsmodel.predict
2 participants