Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Register ApplyAlpha layer templates #499

Merged
merged 3 commits into from
Feb 23, 2022
Merged

Register ApplyAlpha layer templates #499

merged 3 commits into from
Feb 23, 2022

Conversation

thesps
Copy link
Contributor

@thesps thesps commented Feb 22, 2022

As first noticed by @jmitrevs in #490, since the merge of #395 the ApplyAlpha layer is no longer written out. The issue was that the templates weren't registered, so I've added that here. I cherry picked the commit adding the test that @jmitrevs added to expose the problem. It fails on current master, passes on the PR.

I started a quantized_templates.py module anticipating that we may add more specialized functions / layers for handling scale factors etc for the QONNX work later, so their template registration might go there.

@jmitrevs
Copy link
Contributor

I was wondering, should there be a similar setup under the quartus backend?

@thesps
Copy link
Contributor Author

thesps commented Feb 23, 2022

I think eventually, but at the moment the Quartus HLS code doesn't support all of the specialisations (like exponential, for example), so it wouldn't give correct results. But we could look later at synchronising that stuff and moving passes (also qonnx ones probably) into the path of both Vivado and Quartus.

@vloncar vloncar merged commit ee1017b into master Feb 23, 2022
@jmduarte jmduarte deleted the register_applyalpha branch November 2, 2022 02:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants