-
Notifications
You must be signed in to change notification settings - Fork 409
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
set version using setuptools_scm
#479
Conversation
IMO we should move away from hardcoded |
Good point, that solution is a lot nicer. I tried to update it by hand, but it may not be correct yet... For some reason, the autodetection of tags seems off, because if I try python setup.py --version in the this branch, I get: |
@vladimir I was looking into migrating the whole package using PyScaffold: https://pyscaffold.org/en/stable/migration.html See, e.g.: master...jmduarte:pyscaffold What do you think about this approach? |
setuptools_scm
OK @thesps @vloncar, I figured out why currently on this branch I get an hls4ml version of So I'd say this PR is ready to be merged, with perhaps a small change that we should also apply a tag of This also means we should probably make sure to explicitly tag versions of master. And for "bleeding edge" developments, we should perhaps create a new |
4b18b99
to
e889a60
Compare
I am partial to switching to |
Provided the CI tests succeed, I would propose merging this, maybe tomorrow. |
* bump version * add pyproject.toml * update * update * update * gitignore update * try different scheme * lower tolerance pytest * Update setup.cfg
@vloncar @thesps opening this PR for discussion on how to handle automatic version bumping
My thought is it to have a GitHub action to automatically bump patch version on merge of PRs (unless PR has [MINOR] or [MAJOR] in the comment, then we bump the minor or major version as well)