Fix Conv2D with io_type = io_parallel
& Strategy: Resource
#448
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently a
Conv2D
layer withio_type = io_parallel
&Strategy: Resource
gives wrong results. The loops ofim2col_2d_cl
needed reordering.test_cnn_mnist.py
probes the issue. On master branch the problematic combination is excluded, but if we run it we see:Now it can be included, passing with:
I've also reduced the number of MNIST images used in the test from 10000 to 5000, since that test was already the slowest and this PR adds another iteration of it.
Solves issue #375 , and also seen in issue #437.
For completeness: this doesn't touch
io_stream
implementations, they're all fine.I haven't touched
im2col_2d_cf
, but is that even accessible?