Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a test for a model with Reshape as the final layer #444

Merged
merged 1 commit into from
Nov 8, 2021

Conversation

thesps
Copy link
Contributor

@thesps thesps commented Nov 8, 2021

I added a very simple test model with a Reshape as the final layer. The only problem is... this works on both master branch and the PR #443 (ie either with or without repack_stream as the final operation in the myproject.cpp).

I don't know yet what's the significant difference wrt @jmduarte 's gist

@thesps
Copy link
Contributor Author

thesps commented Nov 8, 2021

Correction: the test fails on master branch for io_parallel but works with io_stream.
On #443 the test passes for both io_parallel and io_stream.

@jmduarte jmduarte merged commit 1cb7c20 into reshape_issues Nov 8, 2021
@jmduarte jmduarte deleted the reshape_issues_test branch November 2, 2022 02:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants