Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: check all dependency licenses #98

Closed
wants to merge 2 commits into from
Closed

fix: check all dependency licenses #98

wants to merge 2 commits into from

Conversation

Fdawgs
Copy link
Member

@Fdawgs Fdawgs commented Oct 11, 2023

Previously we were only checking production licenses. This change makes it so we're checking development ones as well.

closes #97

Checklist

@Fdawgs Fdawgs requested review from mcollina, Uzlopak and gurgunday and removed request for mcollina October 11, 2023 17:09
Copy link
Contributor

@Uzlopak Uzlopak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But i would like to have an approval of @mcollina that packages in dev need to have OSi Licenses.

@Fdawgs Fdawgs requested a review from mcollina October 11, 2023 17:16
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm -1 to this change. Ultimately we care about what licenses are used by our users, not what we use locally.

@Fdawgs
Copy link
Member Author

Fdawgs commented Oct 11, 2023

I'm -1 to this change. Ultimately we care about what licenses are used by our users, not what we use locally.

Thanks @mcollina, so is the note at the bottom of pinojs/pino#1762 regarding Blue Oak and Tap not relevant then?

@Fdawgs Fdawgs closed this Oct 12, 2023
@Fdawgs Fdawgs deleted the fix/licenses branch October 12, 2023 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ensure that blueoak licensed packages are detected
3 participants