chore: exclude Node 14 and 16 on macos (#127)

* chore: exclude Node 14 and 16 on macos Related to fastify/.github#37. This is just a proposal, probably not comprehensive of all the places where a similar change may have to occur, simply to capture that this is possible (and I didn't know until now) to exclude combinations, as documented in https://docs.github.com/en/actions/using-jobs/using-a-matrix-for-your-jobs#excluding-matrix-configurations Signed-off-by: Simone Busoli <[email protected]> * remove os matrix from package --------- Signed-off-by: Simone Busoli <[email protected]> Co-authored-by: Gürgün Dayıoğlu <[email protected]>
fastify · Apr 29, 2024 · 04a2d6a · 04a2d6a
1 parent a966a7e
commit 04a2d6a
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 5 deletions.
diff --git a/.github/workflows/plugins-ci-package-manager.yml b/.github/workflows/plugins-ci-package-manager.yml
@@ -12,15 +12,13 @@ on:
 jobs:
   pnpm:
     name: pnpm
-    runs-on: ${{ matrix.os }}
+    runs-on: ubuntu-latest
     permissions:
       contents: read
     strategy:
       matrix:
         node-version: ${{ fromJson(inputs.node-versions) }}
-        os: [ubuntu-latest]
         pnpm-version: [8]
-
     steps:
       - name: Check out repo
         uses: actions/checkout@v4
@@ -45,13 +43,12 @@ jobs:
 
   yarn:
     name: Yarn
-    runs-on: ${{ matrix.os }}
+    runs-on: ubuntu-latest
     permissions:
       contents: read
     strategy:
       matrix:
         node-version: ${{ fromJson(inputs.node-versions) }}
-        os: [ubuntu-latest]
     steps:
       - name: Check out repo
         uses: actions/checkout@v4

diff --git a/.github/workflows/plugins-ci.yml b/.github/workflows/plugins-ci.yml
@@ -110,6 +110,11 @@ jobs:
       matrix:
         node-version: ${{ fromJson(inputs.node-versions) }}
         os: [macos-latest, ubuntu-latest, windows-latest]
+        exclude:
+          - os: macos-latest
+            node-version: 14
+          - os: macos-latest
+            node-version: 16
     steps:
       - name: Check out repo
         uses: actions/checkout@v4