Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initial #1

Merged
merged 12 commits into from
Nov 1, 2017
Merged

Initial #1

merged 12 commits into from
Nov 1, 2017

Conversation

delvedor
Copy link
Member

Initial implementation of what proposed in fastify/fastify#417.
Feedbacks are welcome!

@delvedor delvedor changed the title Initial implementatiom Initial Oct 31, 2017
@delvedor
Updated plugin
8695188 
- added maxHeapUsedBytes and maxRssBytes
- removed loopbench dependency
mcollina
mcollina approved these changes Nov 1, 2017
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. You should also add a config for nginx to try the next server on a 503.

@mcollina
Copy link
Member

mcollina commented Nov 1, 2017

CI is failing

@delvedor
Copy link
Member Author

delvedor commented Nov 1, 2017 •
edited
Loading

You should also add a config for nginx to try the next server on a 503.

Can you rephrase?

CI is failing

I'm working on it ;)

mcollina
mcollina approved these changes Nov 1, 2017
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

mcollina
mcollina approved these changes Nov 1, 2017
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@delvedor delvedor merged commit bafa5a2 into master Nov 1, 2017
@delvedor delvedor deleted the init branch November 1, 2017 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcollina mcollina mcollina approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@delvedor @mcollina