Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: removed comma and comment to make it requirable #1

Merged
merged 1 commit into from
Nov 11, 2020

Conversation

alemagio
Copy link
Contributor

Checklist

I found that the tsconfig file is not possible to require for these 2 issues.
I think that the comment is already clarified in the README, don't you think?

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@fox1t
Copy link
Member

fox1t commented Oct 19, 2020

The comment and the comma where there because tsconfig.json is a JSONC file: https://komkom.github.io/
However, as you found, it makes it un-requirable.

Copy link
Member

@fox1t fox1t left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fox1t fox1t merged commit 4a9011e into fastify:master Nov 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants