Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add option to skip-verification #411

Merged
merged 6 commits into from
Apr 25, 2023

Conversation

yeikel
Copy link
Contributor

@yeikel yeikel commented Apr 24, 2023

When enabled, both author and commit verification are disabled

Closes #378

Checklist

@yeikel
Copy link
Contributor Author

yeikel commented Apr 24, 2023

The second step from the checklist seems outdated because there is no such script called "benchmark"

This new feature is just a flag that runs in O(1) so I do not expect any performance hit of running it anyways

PS C:\Users\Yeikel\WebstormProjects\github-action-merge-dependabot> npm run benchmark
npm ERR! Missing script: "benchmark"
npm ERR!
npm ERR! To see a list of scripts, run:
npm ERR! npm run

npm ERR! A complete log of this run can be found in:
npm ERR! C:\Users\Yeikel\AppData\Local\npm-cache_logs\2023-04-24T13_17_59_007Z-debug-0.log

@@ -20,17 +20,18 @@ Error: Resource not accessible by integration

## Inputs

| input | required | default | description |
Copy link
Contributor Author

@yeikel yeikel Apr 24, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This diff looks a bit large because the table had to be centered to keep the alignment.

To aid in review, you can disable white-spaces from the diff OR you can render it here : https://github.com/yeikel/github-action-merge-dependabot/blob/feat/skip-verification/README.md

The only change besides alignment is to add the newly introduced skip-verification field

action.yml Show resolved Hide resolved
When enabled, both author and commit verification are disabled

Closes fastify#378
@yeikel yeikel force-pushed the feat/skip-verification branch from 339ba57 to 2cc00ba Compare April 24, 2023 13:21
action.yml Show resolved Hide resolved
action.yml Show resolved Hide resolved
action.yml Show resolved Hide resolved
src/action.js Outdated Show resolved Hide resolved
src/action.js Outdated Show resolved Hide resolved
@yeikel yeikel requested a review from climba03003 April 25, 2023 14:36
@simoneb
Copy link
Collaborator

simoneb commented Apr 25, 2023

@yeikel can you please fix the linting errors?

@yeikel
Copy link
Contributor Author

yeikel commented Apr 25, 2023

@yeikel can you please fix the linting errors?

I just did. Thank you

@simoneb simoneb merged commit 9830c7f into fastify:main Apr 25, 2023
@yeikel yeikel deleted the feat/skip-verification branch April 25, 2023 16:24
@simoneb
Copy link
Collaborator

simoneb commented Apr 25, 2023

ouch something must have gone wrong @yeikel , can you please take a look? https://github.com/fastify/github-action-merge-dependabot/actions/runs/4799867042/jobs/8540075811

@yeikel yeikel mentioned this pull request Apr 25, 2023
@yeikel
Copy link
Contributor Author

yeikel commented Apr 25, 2023

ouch something must have gone wrong @yeikel , can you please take a look? https://github.com/fastify/github-action-merge-dependabot/actions/runs/4799867042/jobs/8540075811

Sent #415 and that should fix it

Sorry for the inconvenience

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow custom dependabotAuthor and dependabotCommitter
3 participants