-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add option to skip-verification #411
Conversation
The second step from the checklist seems outdated because there is no such script called "benchmark" This new feature is just a flag that runs in O(1) so I do not expect any performance hit of running it anyways
|
@@ -20,17 +20,18 @@ Error: Resource not accessible by integration | |||
|
|||
## Inputs | |||
|
|||
| input | required | default | description | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This diff looks a bit large because the table had to be centered to keep the alignment.
To aid in review, you can disable white-spaces from the diff OR you can render it here : https://github.com/yeikel/github-action-merge-dependabot/blob/feat/skip-verification/README.md
The only change besides alignment is to add the newly introduced skip-verification
field
When enabled, both author and commit verification are disabled Closes fastify#378
339ba57
to
2cc00ba
Compare
Co-authored-by: KaKa <[email protected]>
Co-authored-by: KaKa <[email protected]>
@yeikel can you please fix the linting errors? |
ouch something must have gone wrong @yeikel , can you please take a look? https://github.com/fastify/github-action-merge-dependabot/actions/runs/4799867042/jobs/8540075811 |
Sent #415 and that should fix it Sorry for the inconvenience |
When enabled, both author and commit verification are disabled
Closes #378
Checklist
npm run test
andnpm run benchmark
and the Code of conduct