Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: block automerge github-action-merge-dependabot major version #114

Merged
merged 5 commits into from
Nov 29, 2021
Merged

feat: block automerge github-action-merge-dependabot major version #114

merged 5 commits into from
Nov 29, 2021

Conversation

Eomm
Copy link
Member

@Eomm Eomm commented Nov 29, 2021 •
edited
Loading

fixes #110

Inspired by #107

@Eomm Eomm requested a review from simoneb November 29, 2021 10:54
@simoneb
Copy link
Collaborator

simoneb commented Nov 29, 2021

Can we please link to an issue?

simoneb
simoneb reviewed Nov 29, 2021
View reviewed changes
Copy link
Collaborator

@simoneb simoneb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have a test which checks that if you're not in the context of a PR but if you provide a pr-number input the action works?

test/action.test.js Outdated Show resolved Hide resolved
@Eomm Eomm changed the title Repo improvements feat: block automerge github-action-merge-dependabot major version Nov 29, 2021
@Eomm
Copy link
Member Author

Eomm commented Nov 29, 2021

Do we have a test which checks that if you're not in the context of a PR but if you provide a pr-number input the action works?

Yeah, it was covered but not clear.
Added a new test case for this scenario

@Eomm Eomm merged commit b0467e8 into main Nov 29, 2021
@Eomm Eomm deleted the repo-improvements branch November 29, 2021 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simoneb simoneb simoneb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Block automerge itself for semver major
2 participants
@Eomm @simoneb