Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixes: object schema carry properties added by raw to $ref #223

Merged
merged 3 commits into from
Jul 26, 2023
Merged

fixes: object schema carry properties added by raw to $ref #223

merged 3 commits into from
Jul 26, 2023

Conversation

dancastillo
Copy link
Member

Checklist

@Fdawgs Fdawgs linked an issue Jul 22, 2023 that may be closed by this pull request
Object schema does not carry properties added by .raw() to a $ref #216
Closed
2 tasks
mcollina
mcollina approved these changes Jul 23, 2023
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Uzlopak
Uzlopak reviewed Jul 23, 2023
View reviewed changes
src/ObjectSchema.js Outdated Show resolved Hide resolved
Uzlopak
Uzlopak reviewed Jul 23, 2023
View reviewed changes
src/ObjectSchema.js Outdated Show resolved Hide resolved
@Uzlopak
Copy link
Contributor

Uzlopak commented Jul 23, 2023

@Fdawgs
Any comment from you regarding Object.assign vs. Spread operator? Here we mix both techniques.

@Fdawgs
Copy link
Member

Fdawgs commented Jul 24, 2023

@Fdawgs Any comment from you regarding Object.assign vs. Spread operator? Here we mix both techniques.

Best to just go all in on the spready boy?

@dancastillo
Copy link
Member Author

@Fdawgs @Uzlopak I applied the changes ptal

Uzlopak
Uzlopak approved these changes Jul 24, 2023
View reviewed changes
Copy link
Contributor

@Uzlopak Uzlopak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@Fdawgs Fdawgs requested a review from aboutlo July 25, 2023 08:29
@aboutlo aboutlo merged commit 6f06632 into fastify:master Jul 26, 2023
14 checks passed
@aboutlo
Copy link
Collaborator

aboutlo commented Jul 26, 2023

@dancastillo thank you for your contribution! 💪

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fdawgs Fdawgs Fdawgs approved these changes

@Uzlopak Uzlopak Uzlopak approved these changes

@mcollina mcollina mcollina approved these changes

@aboutlo aboutlo Awaiting requested review from aboutlo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Object schema does not carry properties added by .raw() to a $ref
5 participants
@dancastillo @Uzlopak @Fdawgs @aboutlo @mcollina