Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(readme): grammatical fixes #107

Merged
merged 1 commit into from
Feb 16, 2021
Merged

docs(readme): grammatical fixes #107

merged 1 commit into from
Feb 16, 2021

Conversation

Fdawgs
Copy link
Member

@Fdawgs Fdawgs commented Feb 16, 2021

Checklist

@coveralls
Copy link

Pull Request Test Coverage Report for Build 571003977

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 99.547%

Totals Coverage Status
Change from base Build 534076812: 0.0%
Covered Lines: 402
Relevant Lines: 402

💛 - Coveralls

@coveralls
Copy link

coveralls commented Feb 16, 2021

Pull Request Test Coverage Report for Build 571029146

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 99.547%

Totals Coverage Status
Change from base Build 534076812: 0.0%
Covered Lines: 402
Relevant Lines: 402

💛 - Coveralls

README.md Outdated
@@ -27,7 +27,7 @@ or

## Usage

```javascript
```javaScript
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why?

Copy link
Member Author

@Fdawgs Fdawgs Feb 16, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoops, corrected with 071e5d3

@Fdawgs Fdawgs requested a review from mcollina February 16, 2021 08:39
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@aboutlo aboutlo merged commit e34dd71 into fastify:master Feb 16, 2021
@Fdawgs Fdawgs deleted the patch-1 branch February 16, 2021 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants