Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add typebox plugin types #27

Merged
merged 1 commit into from
Jul 29, 2022
Merged

feat: add typebox plugin types #27

merged 1 commit into from
Jul 29, 2022

Conversation

Liam-Tait
Copy link
Contributor

@Liam-Tait Liam-Tait commented Jul 29, 2022 •
edited
Loading

Add plugin specific types

  • FastifyPluginCallbackTypebox
  • FastifyPluginAsyncTypebox

Discussed here

Checklist

@Liam-Tait
Copy link
Contributor Author

No script for npm run benchmark, ran npm run test all ok.

@Liam-Tait Liam-Tait marked this pull request as ready for review July 29, 2022 15:11
mcollina
mcollina approved these changes Jul 29, 2022
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina merged commit c1704e1 into fastify:main Jul 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RafaelGSS RafaelGSS RafaelGSS approved these changes

@mcollina mcollina mcollina approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Liam-Tait @mcollina @RafaelGSS