-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: add e2e tests with playwright #99
Conversation
Hmm. problem is, that automerge is in the ci.yml and playwright is not taken into account. So it could result in merging a PR despite the playwright wf failed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm. problem is, that automerge is in the ci.yml and playwright is not taken into account. So it could result in merging a PR despite the playwright wf failed.
I think we could merge this new job in the existing one:
https://github.com/fastify/fastify-swagger-ui/blob/master/.github/workflows/ci.yml
then we can run playwright first if I'm not wrong
Co-authored-by: Manuel Spigolon <[email protected]>
Co-authored-by: Manuel Spigolon <[email protected]>
maybe put everything into the test script of package.json/npm. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Its odd because the integration tests should run after the unit tests, but it works for me...
But lets see what the others say.
CI isn't happy :/ |
@Fdawgs WDYM? |
It's happy now, don't worry 😊 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Changes
Closes #98
Checklist
npm run test
andnpm run benchmark
and the Code of conduct