fix: fix error when updating logo with BaseLayout #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
yashchaddha
reviewed
Jul 19, 2023
Uzlopak
requested changes
Jul 19, 2023
There was a problem hiding this comment.
Your code is one way to solve it.
The issue here is, that swagger-ui supplies two layouts: 'BaseLayout' and 'StandaloneLayout'
In StandaloneLayout we know where the logo needs to be patched. In BaseLayout we dont have a logo, thats why we get that error.
We should check if we have StandaloneLayout and if so, patch it.
Also by checkit if layout is StandaloneLayout the reported error becomes more obvious, why it never could work in BaseLayout
satazor
force-pushed
the
bugfix/logo-basic-layout
branch
from
62c2d06 to
11d6c11
Compare
satazor
force-pushed
the
bugfix/logo-basic-layout
branch
from
11d6c11 to
964c483
Compare
Uzlopak
approved these changes
Jul 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #76
Not sure how to test this. The current test suit checks the HTML response, meaning there's no way to test that actual runtime JavaScript errors occur.
Checklist
npm run testandnpm run benchmarkand the Code of conduct