feat: add indexPrefix option
#186
Conversation
|
@mcollina could you please review this? |
| /** | ||
| * Add an index prefix. This is for when the Fastify server is behind path based routing. ex. NGINX | ||
| */ | ||
| indexPrefix?: string; |
There was a problem hiding this comment.
Can you add a test for this type? We use tsd.
There was a problem hiding this comment.
I'm not sure what you mean. There is a test in test/route.test.js, Is there something else you are looking for?
There was a problem hiding this comment.
Hi @DavidTanner! 👋🏼
You can see an example here. Basically, by running the tsd tool, you can run tests for the TS types. You can then check locally by running npm run typescript, (which will run tsd)
There was a problem hiding this comment.
Happy to push the TS test update if this can help to unlock the release of this PR 😉
There was a problem hiding this comment.
There was a problem hiding this comment.
@dancastillo / @mcollina I think we can close this PR and merge the one above 😊
|
Hi everyone, Have we reached a consensus and a release date? I'm also waiting and want to remove a similar hack (inspired by this PR) that we've implemented to address the relative asset paths problem. Many thanks! |
Checklist
npm run testandnpm run benchmarkand the Code of conduct
Adds a feature flag for #176, #164, #162, and #180