Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: url prefix for favicon #173

Merged
merged 1 commit into from
Sep 13, 2024
Merged

fix: url prefix for favicon #173

merged 1 commit into from
Sep 13, 2024

Conversation

MunifTanjim
Copy link
Contributor

@MunifTanjim MunifTanjim commented Sep 13, 2024 •
edited
Loading

Leftover from #164

Checklist

@MunifTanjim MunifTanjim marked this pull request as ready for review September 13, 2024 10:09
Uzlopak
Uzlopak approved these changes Sep 13, 2024
View reviewed changes
Copy link
Collaborator

@Uzlopak Uzlopak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Uzlopak Uzlopak merged commit 9b12c9a into fastify:master Sep 13, 2024
16 checks passed
@Eomm
Copy link
Member

Eomm commented Sep 14, 2024

Fix released in v5.0.1, but could you open a new PR targeting the v4.x branch? So we can fix that release line too

@MunifTanjim
Copy link
Contributor Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Uzlopak Uzlopak Uzlopak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MunifTanjim @Eomm @Uzlopak