perf: Reduce package size by removing sourceMaps #126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #121
By removing sourceMaps, the size of
@fastify/swagger-uipackage is reduced by~2.7MB.This PR modifies
prepare-swagger-ui.jsto not bundle.mapfiles, but also removes the source map annotation from the source files so browsers do not attempt to retrieve the sourceMaps.Please see the Source Map SPEC for the definition of the sourceMap annotations we are removing.
The annotation comments are slightly different for js/css, and I'm using a regex to handle both cases
//# sourceMappingURL=swagger-ui.js.map/*# sourceMappingURL=swagger-ui.css.map*/Build performance
I was worried searching/removing the annotations from the source files would be quite slow but there does not seem to be a performance impact.
Before
After
Checklist
npm run testandnpm run benchmarkand the Code of conduct