feat: add typings #90
Conversation
| @@ -0,0 +1,35 @@ | |||
| import fastify = require("fastify"); | |||
There was a problem hiding this comment.
I think those come witha license header that we should likely maintain here with some notes.
There was a problem hiding this comment.
I modified the typings (last commit) to use fastify.Plugin and did a minor change on the setHeaders function. Since it is not direct copy of the typings from definitelyTyped I should we still include the header?
There was a problem hiding this comment.
Maybe I could add this?
// Original Definitions by: Leonhard Melzer <https://github.com/leomelzer>
There was a problem hiding this comment.
The creator is a colleague of mine, I'll consult with him.
There was a problem hiding this comment.
We could follow the DefinitelyTyped proposal: https://github.com/DefinitelyTyped/DefinitelyTyped#edit-an-existing-package
// Definitions by: Jannik <https://github.com/jannikkeye>
// Leo <https://github.com/leomelzer>
There was a problem hiding this comment.
That sounds good. I'll set it like you proposed and omit all the DefinitelyTyped related stuff.
test/types/index.ts
Outdated
|
|
||
| const app = Fastify() | ||
|
|
||
| app.register<fastifyStatic.FastifyStaticOptions>(fastifyStatic, options) |
There was a problem hiding this comment.
Can you add a test for sendFile as well?
There was a problem hiding this comment.
Added a test case.
|
Thanks @jannikkeye 🎉 We should make sure to remove the original typings from DefinitetlyTyped to remove confusion:
In DefinitelyTyped: => 2.2.0 or whatever version this release will become :) Can you take care of that after the release? |
|
@leomelzer yes I can take care of that. I'll have to do it for another package as well anyway. 👍 |
This PR adds the typings from DefinitelyTyped (slightly modified) to the main org repo.