Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: respect custom status code when successfully send file #476

Merged
merged 1 commit into from
Oct 17, 2024
Merged

fix: respect custom status code when successfully send file #476

merged 1 commit into from
Oct 17, 2024

Conversation

climba03003
Copy link
Member

Fix #474

Checklist

Uzlopak
Uzlopak approved these changes Oct 16, 2024
View reviewed changes
Copy link
Contributor

@Uzlopak Uzlopak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

dancastillo
dancastillo approved these changes Oct 16, 2024
View reviewed changes
Copy link
Member

@dancastillo dancastillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

mcollina
mcollina approved these changes Oct 17, 2024
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina merged commit 5e6aeb9 into master Oct 17, 2024
13 checks passed
@climba03003 climba03003 deleted the fix-respect-status-code branch October 17, 2024 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gurgunday gurgunday gurgunday approved these changes

@dancastillo dancastillo dancastillo approved these changes

@Uzlopak Uzlopak Uzlopak approved these changes

@mcollina mcollina mcollina approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Sending file with 404 status code dont work
5 participants
@climba03003 @mcollina @Uzlopak @dancastillo @gurgunday