Preserve API invoked internal server error custom messages. #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add an additional properties to the internal server error in case is manually invoked by the user for always allowing the custom message.
delvedor
requested changes
May 2, 2019
I don't think I've understand what kind of test you mean. Like importing httpErrors directly and return an error object created from there? |
delvedor
approved these changes
May 2, 2019
lamweili
added a commit
to lamweili/fastify-sensible
that referenced
this pull request
Jul 31, 2024
…fy#18 Signed-off-by: Lam Wei Li <[email protected]>
4 tasks
mcollina
pushed a commit
that referenced
this pull request
Sep 2, 2024
Signed-off-by: Lam Wei Li <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is aimed to allow the customization of the
500errors that are generated via the available APIs and not from thrown errors, even when theerrorHandleroptions is set totrue.The reasoning behind this change is that having the uncaught exceptions not leaked to the users is a valuable things to have but in the current implementation even the errors generated via the APIs will be masked even if the custom error is passed by the developer. To allow custom
500errors we have to disable the "anti leaking" function.With this PR I've added an additional flag to the error message if it is generated via the API on the
fastify.httpErrorsandreplyobject to allow them to keep their message and not to log an error that is generated always in the same way.Doing this will keep the API usage the same on every error (can set a custom message and the generated error is not logged by default) and keep the masking on thrown errors.