Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move toad-scheduler back to peerDependencies #143

Merged
merged 1 commit into from
Sep 21, 2024

Conversation

gurgunday
Copy link
Member

Reverts the toad-scheduler part of #142

@gurgunday
Copy link
Member Author

gurgunday commented Sep 21, 2024

@kibertoad

Just one last question, is there a reason for fastify to stay as a peerDep? I moved it too in #142 since plugins do an internal check anyway to see if the right range is installed:

fastify: '5.x',

@kibertoad
Copy link
Member

@gurgunday I think it primarily follow a react convention for specifying what versions of framework this release is compatible with. if we do it differently for other plugins, happy to adjust here too

@gurgunday
Copy link
Member Author

@gurgunday I think it primarily follow a react convention for specifying what versions of framework this release is compatible with. if we do it differently for other plugins, happy to adjust here too

Yes, for Fastify Plugins, we don't usually put fastify in peerDeps but devDeps, and that's only for types

@gurgunday gurgunday merged commit c987f22 into fastify:main Sep 21, 2024
11 checks passed
@gurgunday gurgunday deleted the revert-peerDep-change branch September 21, 2024 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants