Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to toad-scheduler 2.0.0 #111

Merged
merged 1 commit into from
Oct 12, 2022
Merged

Upgrade to toad-scheduler 2.0.0 #111

merged 1 commit into from
Oct 12, 2022

Conversation

kibertoad
Copy link
Member

@kibertoad kibertoad commented Oct 12, 2022

Checklist

@kibertoad kibertoad merged commit 8acdd99 into main Oct 12, 2022
@kibertoad kibertoad deleted the chore/toad-scheduler-2 branch October 12, 2022 20:09
@Eomm
Copy link
Member

Eomm commented Oct 12, 2022

Please @kibertoad, could you wait for at least one review from one @fastify/plugins member?

I saw you have already released the v4, could you add a GH release as well?

I did manually the last one: https://github.com/fastify/fastify-schedule/releases/tag/v3.0.2
But I may don't see these kinds of changes in future

@kibertoad
Copy link
Member Author

kibertoad commented Oct 12, 2022

@Eomm Sorry for that. There wasn't much to review, it was pretty much straightforward a bump. But I'll make sure to wait next time!

Created the release as well.

@Fdawgs
Copy link
Member

Fdawgs commented Oct 16, 2022

@kibertoad, tag and release appear to be missing the leading v, which was present in other releases?
Not massively important, just nice to be consistent.

@kibertoad
Copy link
Member Author

@Fdawgs my bad. will rename release and will be more careful in the future, sorry

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants