Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove elseif from the lua script #334

Merged
merged 1 commit into from
Oct 30, 2023
Merged

remove elseif from the lua script #334

merged 1 commit into from
Oct 30, 2023

Conversation

gurgunday
Copy link
Member

We are returning in each case so we don't need the elseif

Can't believe I realized this after it got merged

@Uzlopak Uzlopak merged commit 7608e19 into fastify:master Oct 30, 2023
7 checks passed
@gurgunday gurgunday deleted the minor branch October 30, 2023 10:20
@Eomm
Copy link
Member

Eomm commented Oct 30, 2023

Does it mean we don't have a test for it? 😏

@gurgunday
Copy link
Member Author

gurgunday commented Oct 30, 2023

Haha no no, we do have tests, this change didn't alter Redis's behavior

There are return statements inside the conditional checks, eliminating the need for an else if clause; a return statement would already exit the control flow

So it's just a minor personal preference refactor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants