Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add the "key" in the "onExceeding" and "onBanReach" #258

Merged
merged 5 commits into from
Aug 30, 2022
Merged

add the "key" in the "onExceeding" and "onBanReach" #258

merged 5 commits into from
Aug 30, 2022

Conversation

SergioGlorias
Copy link
Contributor

Checklist

@Uzlopak
Copy link
Contributor

Uzlopak commented Aug 28, 2022

why the key? why not the actual IP?

@SergioGlorias
Copy link
Contributor Author

why the key? why not the actual IP?

i'm working on some things that can't directly be the IP the default key
and there are people who use keys different from the default IP

onBanReach already provides the key is a big help
only these two functions do not have the key

Uzlopak
Uzlopak approved these changes Aug 28, 2022
View reviewed changes
Copy link
Contributor

@Uzlopak Uzlopak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

mcollina
mcollina approved these changes Aug 29, 2022
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

mcollina
mcollina requested changes Aug 29, 2022
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for opening a PR! Can you please add a unit test?

@SergioGlorias
Copy link
Contributor Author

@mcollina I don't have much practice with this but could you check?

mcollina
mcollina approved these changes Aug 30, 2022
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina merged commit 011bbb2 into fastify:master Aug 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcollina mcollina mcollina approved these changes

@Uzlopak Uzlopak Uzlopak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SergioGlorias @Uzlopak @mcollina