Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix eslint #485

Merged
merged 1 commit into from
Sep 29, 2023
Merged

fix eslint #485

merged 1 commit into from
Sep 29, 2023

Conversation

gurgunday
Copy link
Member

@gurgunday gurgunday commented Sep 29, 2023

I'm getting the following error in every JS file's first line:

Parsing error: ESLint was configured to run on `<tsconfigRootDir>/index.js` using `parserOptions.project`: .../fastify-multipart/tsconfig.eslint.json
However, that TSConfig does not include this file.

As a result no actual static checking happens

This PR simplifies the config and fixes that issue

Checklist

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina merged commit 109a116 into fastify:master Sep 29, 2023
15 checks passed
@gurgunday gurgunday mentioned this pull request Oct 5, 2023
4 tasks
@gurgunday gurgunday deleted the fix-eslint branch October 13, 2023 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants